Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLO docs overhaul #2958

Merged
merged 9 commits into from
Aug 22, 2023
Merged

SLO docs overhaul #2958

merged 9 commits into from
Aug 22, 2023

Conversation

apoorv-garg
Copy link
Collaborator

@apoorv-garg apoorv-garg commented Aug 21, 2023

Purpose of this pull request

  • Reordering of sections on create slo page.
  • Removed the duplicate documentation for sumologic_slo_output and lookup table from create slo page.
  • Removed SLO use cases page. It has old queries and just reconstructs existing panels, which is already covered in SLO dashboard page docs.
  • Improvements to SLO dashboard page

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@cla-bot
Copy link

cla-bot bot commented Aug 21, 2023

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we'll add you to our approved list of contributors.

@apoorv-garg apoorv-garg requested a review from tarunk2 August 21, 2023 08:45
@cla-bot
Copy link

cla-bot bot commented Aug 21, 2023

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we'll add you to our approved list of contributors.

@cla-bot
Copy link

cla-bot bot commented Aug 21, 2023

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we'll add you to our approved list of contributors.

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Aug 21, 2023
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, @apoorv-garg ! Thanks so much for doing. Just had some minor formatting suggestions.

kimsauce and others added 2 commits August 21, 2023 10:12
…umologic-documentation into apoorv-slo-docs-improvements
Co-authored-by: Kim <56411016+kimsauce@users.noreply.github.com>
@apoorv-garg
Copy link
Collaborator Author

Excellent job, @apoorv-garg ! Thanks so much for doing. Just had some minor formatting suggestions.

Thanks for the suggestions, applied.

@apoorv-garg apoorv-garg enabled auto-merge August 22, 2023 06:10
@kimsauce kimsauce disabled auto-merge August 22, 2023 06:27
@kimsauce kimsauce enabled auto-merge August 22, 2023 06:27
@kimsauce kimsauce added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit f95b3b2 Aug 22, 2023
@kimsauce kimsauce deleted the apoorv-slo-docs-improvements branch August 22, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants