-
Notifications
You must be signed in to change notification settings - Fork 137
AWSO 2.13.0: Fixed app install to Admin Recommended Folder and CVE fixes #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated SAM for sumo_app_utils
Fixed app install to Admin Recommended Folder
Updated testcases for sumo_app_utils
Updated Non AWSO SAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the AWS Observability utilities to support installing apps into the Admin Recommended folder and addresses dependency CVEs.
- Propagates and standardizes is_admin handling across content operations (create/import/install/copy/delete) and adds header support to GET requests.
- Fixes and refines app folder creation/sharing logic, including ability to add/remove org-wide sharing.
- Bumps versions across templates and requirements (including requests to 2.32.5/≥2.32.4) and updates packaging artifacts.
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sumologic-app-utils/sumo_app_utils.yaml | Bumps SemanticVersion and CodeUri to 2.0.21 for app utils. |
| sumologic-app-utils/src/sumoresource.py | Adds is_admin flows, Admin Recommended folder utilities, sharing add/remove; multiple parameter renames and API header usage. |
| sumologic-app-utils/src/sumologic.py | Adds headers to get(); standardizes is_admin parameters; propagates admin-mode headers to content APIs. |
| sumologic-app-utils/packaged_sumo_app_utils.yaml | Updates packaged metadata and CodeUri to 2.0.21. |
| sumologic-app-utils/deploy.sh | Increments version to 2.0.21. |
| sumologic-app-utils/Test/SampleTemplate.yaml | Updates example template to 2.0.21, sample bucket/values, and adds orgid where needed. |
| securityhub-org/.../sam/requirements.txt | Bumps requests to 2.32.5. |
| loggroup-lambda-connector/test/requirements.txt | Bumps requests to ≥2.32.4. |
| cloudwatchlogs-with-dlq/requirements.txt | Bumps requests to 2.32.5. |
| cloudwatchevents/test/requirements.txt | Bumps requests to 2.32.5. |
| cloudwatchevents/guarddutybenchmark/template_v2.yaml | Bumps SemanticVersion to 1.0.18 and app utils reference to 2.0.21. |
| cloudwatchevents/guarddutybenchmark/packaged.yaml | Updates packaged artifact URIs and versions. |
| cloudwatchevents/guarddutybenchmark/deploy.sh | Increments version to 1.0.18. |
| cloudtrailbenchmark/testdeploy.sh | Increments version to 1.0.21. |
| cloudtrailbenchmark/template.yaml | Bumps SemanticVersion to 1.0.21 and app utils reference. |
| cloudtrailbenchmark/packaged.yaml | Updates packaged artifact URIs and versions. |
| awsautoenableS3Logging/sumologic-s3-logging-auto-enable.yaml | Bumps SemanticVersion to 1.0.18 and app utils CodeUri. |
| awsautoenableS3Logging/packaged.yaml | Updates packaged metadata and app utils CodeUri. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.