Skip to content

Updating runtimes of python and nodeJS #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Updating runtimes of python and nodeJS #172

merged 9 commits into from
Oct 25, 2023

Conversation

himsharma01
Copy link
Contributor

No description provided.

@himsharma01 himsharma01 requested a review from a team as a code owner September 11, 2023 09:00
@himsharma01 himsharma01 removed the request for review from a team September 11, 2023 09:00
@rymancl
Copy link

rymancl commented Sep 11, 2023

Looking forward to this! We just attempted to upgrade all of our cloudwatchlogs-with-dlq Lambda functions from nodejs16.x to nodejs18.x and they all blew up.

image

Copy link
Contributor

@npande npande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himsharma01 himsharma01 merged commit 23cbb63 into main Oct 25, 2023
@himsharma01
Copy link
Contributor Author

Looking forward to this! We just attempted to upgrade all of our cloudwatchlogs-with-dlq Lambda functions from nodejs16.x to nodejs18.x and they all blew up.

image

@rymancl We have the released the lambdas with latest runtime supported. Thank you for your patience.
Also make sure to checkout the our latest AWS Observability v2.7.0 release.

@scastria
Copy link

I still see the same error when switching to nodejs18. Have the S3 buckets where this lambda code is located been updated with this change?

@scastria
Copy link

I just ran:

aws s3 cp s3://appdevzipfiles-us-west-2/cloudwatchlogs-with-dlq.zip .

to check the content and I don't see any of the changes in the code for this fix

@rymancl
Copy link

rymancl commented Oct 25, 2023

Confirmed S3 is not updated. Last updated in January.

aws s3api head-object --bucket appdevzipfiles-us-west-2 --key cloudwatchlogs-with-dlq.zip

{
    "AcceptRanges": "bytes",
    "LastModified": "2023-01-13T12:14:42+00:00",
    "ContentLength": 732358,
    "ETag": "\"9ae46e697262edd35468a8635e05970f\"",
    "ContentType": "binary/octet-stream",
    "ServerSideEncryption": "AES256",
    "Metadata": {}
}

@himsharma01
Copy link
Contributor Author

himsharma01 commented Oct 25, 2023

@rymancl @scastria the s3 location of the file has been changed to cloudwatchLogsDLQ/v1.2.0/cloudwatchlogs-with-dlq.zip inside s3 bucket appdevzipfiles-us-west-2.

@rymancl
Copy link

rymancl commented Oct 25, 2023

@rymancl @scastria the s3 location of the file has been changed to cloudwatchLogsDLQ/v1.2.0/cloudwatchlogs-with-dlq.zip inside s3 bucket appdevzipfiles-us-west-2.

Interesting, thanks for noting that.

But that file still shows as last updated almost 2 months ago.

aws s3api head-object --bucket appdevzipfiles-us-west-2 --key cloudwatchLogsDLQ/v1.2.0/cloudwatchlogs-with-dlq.zip

{
    "AcceptRanges": "bytes",
    "LastModified": "2023-09-07T13:23:03+00:00",
    "ContentLength": 732472,
    "ETag": "\"5f07cbcb6a6345c64e1876608c5d94ff\"",
    "ContentType": "binary/octet-stream",
    "ServerSideEncryption": "AES256",
    "Metadata": {}
}

@scastria
Copy link

I do see the change in that new location. Testing now...

@scastria
Copy link

Everything looks great! Thanks.

@npande npande deleted the python-js-update branch May 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants