Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest #10

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Rest #10

merged 3 commits into from
Jan 10, 2021

Conversation

gpb01
Copy link
Contributor

@gpb01 gpb01 commented Jan 9, 2021

Enhancements in comments. Added sequential order to parameters.
Ignore macOS .DS_Store files.

gpb01 added 2 commits January 9, 2021 11:47
Enhancements in comments. Added sequential order to parameters.
Ignore macOS .DS_Store files
@qniens
Copy link
Contributor

qniens commented Jan 9, 2021

Is this commit missing some files? I see CLIENT_TIMEOUT and the AUTH which are both new?

@SukkoPera
Copy link
Owner

No, it's for the development branch (namd rest).

@qniens
Copy link
Contributor

qniens commented Jan 9, 2021

You're correct. My bad.

@SukkoPera
Copy link
Owner

SukkoPera commented Jan 9, 2021

No problem. This branch will soon become v 0.9.1 and we'll need lots of testing :).

@qniens
Copy link
Contributor

qniens commented Jan 10, 2021

Sure! I've been using the library a lot.

@SukkoPera SukkoPera merged commit a184d64 into SukkoPera:rest Jan 10, 2021
@SukkoPera
Copy link
Owner

SukkoPera commented Jan 15, 2021

@qniens the 1.0rc was just released, see https://github.com/SukkoPera/Webbino/releases/tag/v0.9.95.

It would be great if you could please test it and report any issues you might find.

@qniens
Copy link
Contributor

qniens commented Jan 15, 2021

@SukkoPera Yes I saw the notifications popping up in my email. I will test it!

@qniens
Copy link
Contributor

qniens commented Jan 21, 2021

Hi @SukkoPera, I have updated the Webbino code v0.9.97 and it runs without major problems on a custom ATSAMD51G19A-MU board. This means it will run fine on every Adafruit SAMD51 / M4 board.

The only issue is the
return pgm_read_word (&(this -> length));
in
FlashStorage.h

But I see the comments there that it is on the TODO list.

Also TAG replacement now runs on every file, instead on only html files. This is problematic for Jquery script using the $ sign. I suggest to use ` as the default tag delimiter. As this character is less frequent being used.

@SukkoPera
Copy link
Owner

Thanks a lot for your testing @qniens!

Tag replacement is only done for MIME types having true as the last parameter here. Do you think it would be better to disable it for .js files?

@qniens
Copy link
Contributor

qniens commented Jan 22, 2021

@SukkoPera Yes I think it is better to disable it by default for .js files. This will improve the initial user experience with the Webbino library. It took me awhile to find out why the minimized version of jQuery won't load. It was because of the TAG delimiter changing the source code of the js file.

In my setup I changed it to ` or ~. But both are also legit operators in JS.

I know the library is optimized for small memory MCU, but it works like a charm on faster IC like the SAMD51. I can make dynamic website(with the help of JQuery) like normal and just store it to FlashMemory.

@SukkoPera
Copy link
Owner

OK, done, thanks for the advice!

The problem with ` and ~ is that they are pretty hard to type on some non-English keyboards, Italian for instance (unless you are a Linux user :)). I'll leave it to $ but I'll add some words about it in the docs.

Thanks for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants