-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest #10
Rest #10
Conversation
Enhancements in comments. Added sequential order to parameters.
Ignore macOS .DS_Store files
Is this commit missing some files? I see CLIENT_TIMEOUT and the AUTH which are both new? |
No, it's for the development branch (namd rest). |
You're correct. My bad. |
No problem. This branch will soon become v 0.9.1 and we'll need lots of testing :). |
Sure! I've been using the library a lot. |
@qniens the 1.0rc was just released, see https://github.com/SukkoPera/Webbino/releases/tag/v0.9.95. It would be great if you could please test it and report any issues you might find. |
@SukkoPera Yes I saw the notifications popping up in my email. I will test it! |
Hi @SukkoPera, I have updated the Webbino code v0.9.97 and it runs without major problems on a custom ATSAMD51G19A-MU board. This means it will run fine on every Adafruit SAMD51 / M4 board. The only issue is the But I see the comments there that it is on the TODO list. Also TAG replacement now runs on every file, instead on only html files. This is problematic for Jquery script using the $ sign. I suggest to use ` as the default tag delimiter. As this character is less frequent being used. |
@SukkoPera Yes I think it is better to disable it by default for .js files. This will improve the initial user experience with the Webbino library. It took me awhile to find out why the minimized version of jQuery won't load. It was because of the TAG delimiter changing the source code of the js file. In my setup I changed it to ` or ~. But both are also legit operators in JS. I know the library is optimized for small memory MCU, but it works like a charm on faster IC like the SAMD51. I can make dynamic website(with the help of JQuery) like normal and just store it to FlashMemory. |
OK, done, thanks for the advice! The problem with ` and ~ is that they are pretty hard to type on some non-English keyboards, Italian for instance (unless you are a Linux user :)). I'll leave it to $ but I'll add some words about it in the docs. Thanks for all your help! |
Enhancements in comments. Added sequential order to parameters.
Ignore macOS .DS_Store files.