chore: support Python 3.12 #430
Conversation
Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
| @@ -22,7 +22,7 @@ Installation | |||
|
|
|||
| .. _installation: | |||
|
|
|||
| Substrafl and Substra are compatible with Python versions 3.9, 3.10 and 3.11 on Windows, MacOS and Linux. | |||
| Substrafl and Substra are compatible with Python versions 3.9, 3.10, 3.11 and 3.12 on Windows, MacOS and Linux. | |||
There was a problem hiding this comment.
Do we still say that we are compatible with Python 3.9 if we are removing testing on it?
There was a problem hiding this comment.
We are still testing in Python 3.9 in the CI and in all other repos.
| @@ -15,7 +15,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-22.04] | |||
| python: ["3.8", "3.9", "3.10", "3.11"] | |||
| python: ["3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
Following @guilhem-barthes' comment, python 3.9 has been removed here
There was a problem hiding this comment.
It was intentional, since I realised that the documentation CI is still running in 3.8 as of today despite Python 3.8 support being dropped since March, and I was afraid that this would happen again for 3.9.
But I can also add a line in the Linear card instead and keep the CI running on 3.9 until that happens if you think it's better :)
There was a problem hiding this comment.
Fair enough, looks ok remove IMO!
Adding support for Python 3.12, in particular in the CI.
Dropping 3.8 and 3.9 from the CI (both versions at the same time, since we forgot to do it last time).