Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vehicle destruction sync #2197

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improve vehicle destruction sync #2197

wants to merge 10 commits into from
+118 −72

Conversation

SpaceMonkeyy86
Copy link
Contributor

Properly moves vehicle destroying to the new entities system.

Coding-Hen
Coding-Hen approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Coding-Hen Coding-Hen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGCW. Good to have it moved over to the new system and remove code complexity

@SpaceMonkeyy86
Copy link
Contributor Author

Cyclops wrecks are also synced now

@dartasen
Copy link
Member

Works fine IG :

  • We can see seamoth & exosuit being destroyed
  • We can see cyclops exploding
  • Wrecks are still here upon re-joining (with items, upgrades in it)

Bugs we noticed :

  • Wrecks will re-explode upon re-joining
  • Decoys slots are gone upon re-joining

@SpaceMonkeyy86 SpaceMonkeyy86 changed the title Fix vehicle destroy not syncing Improve vehicle destruction sync Nov 18, 2024
@SpaceMonkeyy86
Copy link
Contributor Author

Works fine IG :

* We can see seamoth & exosuit being destroyed

* We can see cyclops exploding

* Wrecks are still here upon re-joining (with items, upgrades in it)

Bugs we noticed :

* Wrecks will re-explode upon re-joining

* Decoys slots are gone upon re-joining

Both of these should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coding-Hen Coding-Hen Coding-Hen approved these changes

@tornac1234 tornac1234 Awaiting requested review from tornac1234

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpaceMonkeyy86 @dartasen @Coding-Hen