-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water Park experience improvements #2132
base: master
Are you sure you want to change the base?
Water Park experience improvements #2132
Conversation
tornac1234
commented
Apr 29, 2024
•
edited
Loading
edited
- Fix fishes broadcasting global coordinates while in water parks
- Sync creature hatching
- Sync creature mating
- Fix simulation ownership not being given when first placing buildings
- Fix some creature respawner having a cell level 100 (not handled by server)
…emporary), fix crabsnake callback not working
…pieces (water parks, reactors ...)
Ready for review 😎 (and to be tested 🎮) |
NitroxClient/GameLogic/Spawning/WorldEntities/GlobalRootEntitySpawner.cs
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/GlobalRootEntitySpawner.cs
Show resolved
Hide resolved
} | ||
public EggMetadata(float timeStartHatching, float progress) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
public EggMetadata(float timeStartHatching, float progress) | |
} | |
public EggMetadata(float timeStartHatching, float progress) |
/// </summary> | ||
public sealed partial class CreatureEgg_Hatch_Patch : NitroxPatch, IDynamicPatch | ||
{ | ||
public static readonly MethodInfo TARGET_METHOD = Reflect.Method((CreatureEgg t) => t.Hatch()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we don't need to deal with telling the other clients that it has hatched as this will be dealt with by the metadata processor/ async born patch below and we won't cause a race condition by sending the destroyed entity first?
|
||
using (new GUILayout.HorizontalScope()) | ||
{ | ||
GUILayout.Label("Simulating state", GUILayout.Width(LABEL_WIDTH)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we haven't got it on these so far but do we want to have the multi language support on them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would definitely say no. These are debug tools intended only for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that as well, just thought I would see people's appetite.
Also being a dev tool add and removing template strings would be a pain