Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Park experience improvements #2132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tornac1234
Copy link
Collaborator

@tornac1234 tornac1234 commented Apr 29, 2024

  • Fix fishes broadcasting global coordinates while in water parks
  • Sync creature hatching
  • Sync creature mating
  • Fix simulation ownership not being given when first placing buildings
  • Fix some creature respawner having a cell level 100 (not handled by server)

@tornac1234 tornac1234 added Type: bug Area: bases Related to base building or interior game objects Type: enhancement Issue is to be solved by implementing new features labels Apr 29, 2024
@tornac1234 tornac1234 marked this pull request as ready for review May 4, 2024 12:04
@tornac1234
Copy link
Collaborator Author

tornac1234 commented May 4, 2024

Ready for review 😎 (and to be tested 🎮)

Comment on lines +21 to +22
}
public EggMetadata(float timeStartHatching, float progress)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
public EggMetadata(float timeStartHatching, float progress)
}
public EggMetadata(float timeStartHatching, float progress)

/// </summary>
public sealed partial class CreatureEgg_Hatch_Patch : NitroxPatch, IDynamicPatch
{
public static readonly MethodInfo TARGET_METHOD = Reflect.Method((CreatureEgg t) => t.Hatch());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we don't need to deal with telling the other clients that it has hatched as this will be dealt with by the metadata processor/ async born patch below and we won't cause a race condition by sending the destroyed entity first?


using (new GUILayout.HorizontalScope())
{
GUILayout.Label("Simulating state", GUILayout.Width(LABEL_WIDTH));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we haven't got it on these so far but do we want to have the multi language support on them?

Copy link
Member

@Jannify Jannify Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would definitely say no. These are debug tools intended only for us.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that as well, just thought I would see people's appetite.

Also being a dev tool add and removing template strings would be a pain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: bases Related to base building or interior game objects Type: bug Type: enhancement Issue is to be solved by implementing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants