-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packet serializer #1798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise is fine, but we should move the changes to binary pack to a repo on this org. I've given you write perms to the https://github.com/SubnauticaNitrox/BinaryPack so you can push to this remote directly.
Edit: code is moved to repo
4d5257e
to
38fea61
Compare
3f3e270
to
48c8451
Compare
Ok, the pr already seems pretty solid.
|
Parameter constructors have been implemented, all that's left to do now is in-game testing, fixing the unit tests, and uploading the library to NuGet. |
It's done 🎉 |
In |
Doing a quick in-game test it seems like something partially breaks the game/sync. Every time I joined a world both players joined in different (fully repaired) escapepods which weren't visible to the other. While they could see each other flora wasn't synced either. Do you have the same result or something different? |
Yes, I got that same issue. I briefly looked into it but couldn't find anything wrong with the class definitions so I concluded that some other part of the codebase was at fault. If it helps there is a |
Tested IG with Jannify Might need to do a bigger test sessions with 5+ players doing a casual gameplay |
Really glad development is coming along nicely. I got to test all the new changes |
Replaces the current serializer, BinaryFormatter, with a modified version of BinaryPack:
https://github.com/SubnauticaNitrox/BinaryPack
This serializer is faster, uses less memory, is more secure, and produces a smaller output.
Resolves a part of #1473.