Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: View by folder (and other options) #173

Closed
tcryuvgbhjkl opened this issue Nov 3, 2023 · 2 comments · Fixed by #193
Closed

Feature request: View by folder (and other options) #173

tcryuvgbhjkl opened this issue Nov 3, 2023 · 2 comments · Fixed by #193
Labels
enhancement New feature or request

Comments

@tcryuvgbhjkl
Copy link

Currently Submariner allows to view by Artist, Album and Podcast. Would it be possible to add more views? In my case specifically interested by folder view since the folders are organized but id3 tags are a mess.
@tcryuvgbhjkl tcryuvgbhjkl added the enhancement New feature or request label Nov 3, 2023
@NattyNarwhal
Copy link
Member

Unfortunately, Submariner right now is actually doing the worst of both worlds and beating the folder based view into an artist-album-track hierarchy. This is OK for things like Navidrome that basically make up a fake directory hierarchy based on tags (which is really funny, because Submariner predates Navidrome by a lot), but it's not so good for Subsonic, which presents the actual filesystem view.

An issue to get us onto the ID3 based model that makes more sense for Subsonic is GH-73, but I'm keeping this as filesystem based browsing could be done too. It's mostly just ugly data model migration stuff; I hope I can do it without a flag day.

NattyNarwhal added a commit that referenced this issue Nov 9, 2023
@NattyNarwhal
Use tag instead of directory based metadata
ba596a4 
Avoids the ugly contorting of the data model from arbitrary directory
structure to artist-album-track. This should make the API requests
actually match the original data model.

- I have only tested with Navidrome. Since Navidrome uses identical IDs
  for the fake hierarchy and the tags, the transition is seamless.
- I haven't tested Subsonic. Since it uses different IDs for directories
  vs. tags, it's likely this won't be so smooth. Recreate your server.
  (Could this be handled better?)
- Nor have I tested other implementations.
- Podcasts may be busted. The podcast functionality is really bitrotted
  and not well tested regardless.
- We could do real directory hierarchies (GH-173) correctly, with a data
  model actually modelling... directories.
@NattyNarwhal NattyNarwhal mentioned this issue Nov 9, 2023
Merged
NattyNarwhal added a commit that referenced this issue Feb 8, 2024
@NattyNarwhal
Initial directory view support
5551ffd 
By popular request in GH-173.

The modelling might not be the best, but avoids impacting other stuff as
much as possible. Features a view with miller columns.

Current issues:

* Replaces podcasts (for now)
* No way to interact or drag tracks out
* Text at bottom gets weird with fixed scrollbar
* New columns won't force it to scroll left
@NattyNarwhal NattyNarwhal mentioned this issue Feb 8, 2024
Merged
@NattyNarwhal
Copy link
Member

This should be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Directory view SubmarinerApp/Submariner
2 participants
@NattyNarwhal @tcryuvgbhjkl