[ST4] Make editing scheme/theme, OS aware when the corresponding is set to auto.#330
Merged
FichteFoll merged 4 commits intoSublimeText:masterfrom Jun 6, 2021
Merged
Conversation
…auto. This commit makes editing color schemes, OS mode aware when the color_scheme setting is set to the auto mode.
This commit makes editing theme, OS mode aware when the theme setting is set to the auto mode.
FichteFoll
reviewed
Jan 31, 2021
Member
FichteFoll
left a comment
FichteFoll
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I'll hold off merging this until the next build is out and I can properly test, since I'm personally skipping 4096 due to the forced titlebars and I could see others doing that as well, meaning I can't only support the latest build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to make editing color schemes/themes OS aware, when the corresponding settings are set to
auto. The quick panel item that is active is selected and has an annotation ofActivebased on the OS appearance mode.Resolves #329