inline_output does not work with R kernel

[randy3k]

Great job of migrating to the jupyter client.

When the option inline_output is set true, there is no inline output when the R code is run. I can see that from the console the code was executed correctly by the kernel but Hermes doesn't pick up the result and show it. Nevertheless, plots are shown correctly inline and everything works if inline_output is false.

Code sample:

a = 1
a

plot(1:100)

Console log:

{'buffers': [], 'msg_id': '69e13612-7c50-4751-b292-bf35271b3657', 'parent_header': {'msg_id': 'e0b75075-5e7d188c43005a4a0c462f30', 'date': datetime.datetime(2018, 7, 12, 17, 6, 23, 661297, tzinfo=tzutc()), 'username': 'Randy', 'msg_type': 'execute_request', 'version': '5.3', 'session': '7e86bc5f-c7f908b6bdabb89525f3583b'}, 'msg_type': 'execute_input', 'content': {'execution_count': 10, 'code': 'a'}, 'header': {'msg_id': '69e13612-7c50-4751-b292-bf35271b3657', 'date': datetime.datetime(2018, 7, 12, 17, 6, 23, 664965, tzinfo=datetime.timezone.utc), 'username': 'Randy', 'msg_type': 'execute_input', 'version': '5.0', 'session': '7e86bc5f-c7f908b6bdabb89525f3583b'}, 'metadata': {}}
{'buffers': [], 'msg_id': 'ebd8ffe3-9cf1-4c99-b49c-9fe73fe94300', 'parent_header': {'msg_id': 'e0b75075-5e7d188c43005a4a0c462f30', 'date': datetime.datetime(2018, 7, 12, 17, 6, 23, 661297, tzinfo=tzutc()), 'username': 'Randy', 'msg_type': 'execute_request', 'version': '5.3', 'session': '7e86bc5f-c7f908b6bdabb89525f3583b'}, 'msg_type': 'display_data', 'content': {'data': {'text/plain': '[1] 1', 'text/markdown': '1', 'text/latex': '1', 'text/html': '1'}, 'metadata': {}}, 'header': {'msg_id': 'ebd8ffe3-9cf1-4c99-b49c-9fe73fe94300', 'date': datetime.datetime(2018, 7, 12, 17, 6, 23, 678995, tzinfo=datetime.timezone.utc), 'username': 'Randy', 'msg_type': 'display_data', 'version': '5.0', 'session': '7e86bc5f-c7f908b6bdabb89525f3583b'}, 'metadata': {}}

[ngr-t]

Thank you for the comment and tracking the issue!
It seems that messages from some channel are not shown inline.

[randy3k]

I believe it is because iRKernal uses display_data to send back the result.

[SamiPirbay]

This can be fixed in kernel.py, in _write_mime_data_to_view
Currently, mime types "text/plain", "text/markdown", and "text/html" are not shown inline. It can be done by calling _write_inline_html_phantom just after _write_text_to_view or _write_phantom

I can do it but it'll take a couple of weeks as I am travelling at the moment.

[ngr-t]

@SamiPirbay Thanks. I will be able to fix it by myself.

I'm little worried about which type should we use, "text/plain" or "text/html". Because minihtml doesn't render several tags often included in html messages from Jupyter kernels, "text/plain" might be the choice.

[randy3k]

"text/plain" might be the choice.

I agree

[ngr-t]

Fixed by #48. Now I'm preparing release including this.

[randy3k]

Thanks. I confirm that it is fixed.