Skip to content

Commit

Permalink
r
Browse files Browse the repository at this point in the history
  • Loading branch information
Subilan committed Jan 23, 2024
1 parent 7930ea6 commit 8b3dd12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ We all know most of the mods can totally work perfectly without any Internet con

However, sometimes we can also see web requests done synchronously, [as in Citadel](https://github.com/AlexModGuy/Citadel/blob/master/src/main/java/com/github/alexthe666/citadel/web/WebHelper.java). The difference it made can be subtle if the quality connection is quite high, but it can also block the whole startup process [for over 10 minutes](https://github.com/AlexModGuy/Citadel/issues/145) if there's some limit in the connection or the quality is poor.

It's OK for local players or online clients, because the former barely experience *that* poor Internet connection at home or other places suitable for gaming, or they can just think it as some sort of lag instead of thread blocking caused by Internet connection. And the latter will not see any of the problem at all, because the whole process is done on server startup. *However, if it's not done on startup but in game running, the server might be unprecedentedly disappointing because the whole world will then lag randomly, depending on the network quality.* In contrast, for server owners, it can be a pain in the ass since there will always be some extra minutes used to finish some unimportant work, and it can take quite long time to find the reason for this kind of delay, because _doing synchronous web request for listing patreons is a rare thing_.
It's OK for local players or online clients, because the former barely experience *that* poor Internet connection at home or other places suitable for gaming, or they can just think it as some sort of lag instead of thread blocking caused by Internet connection. And the latter will not see any of the problem at all, because the whole process is done on server startup. *However, if it's not done on startup but in game running, the server might be unprecedentedly disappointing because the whole world will then lag randomly, depending on the network quality.* In contrast, for server owners, it can be a pain in the ass since there will always be some extra minutes used to finish some unimportant work, and it can take quite long time to find the reason for this kind of delay.

Considering the Internet connection quality varies among servers and actually the blocking of startup is unreasonable and time-wasting, this project helps server owners with similar issues get the version _with_ the timeout. And 3 seconds (by default) is quite enough for minor web requests.

Expand Down

0 comments on commit 8b3dd12

Please sign in to comment.