Revamp ruby rendering to support text-based and container-based styling #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickok
reviewed
Dec 7, 2021
| dom.Node? textNode; | ||
| String? textNode; | ||
| List<Widget> widgets = <Widget>[]; | ||
| //TODO calculate based off of parent font size. |
Contributor
Author
There was a problem hiding this comment.
Should we really calculate based off parent font size though? I feel that calculating based on whatever styling is set on the ruby tag should be sufficient, and now we even allow for specific styling on rt itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #914