-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated non-breaking dependencies #636
Conversation
Thanks for helping out. This partly conflict with the 2.0.0-final PR of #603. More importantly, you are using a manual override of some chewie version. I don't think we can accept that for our production release. Is this jsut because you want to update to the latest video_player? |
It won't allow you to publish to Pub in the first place, all dependencies must be exclusively from Pub. |
can you review again i restored chewie |
Version 2.0.0 still is incompatible for me
I am using
|
@adrianvintu I know these are very annoying, but there isn't much we can do here as they are dependencies of our dependencies. You are probably best off using a dep_override on wakelock. Alternatively you could use chewie yourself for video playback instead of flick_video_player. |
@erickok sorry to hear that. I am quite a beginner in Flutter, so I don't really understand how these dependencies work. Should I open a ticket on the chewie side and ask them to update wakelock? I am thinking about switching to chewie btw, but these changes always come with a lot of pain. |
See https://dart.dev/tools/pub/dependencies#dependency-overrides on how to do a dependency override for your app. You can fix wakelock to ^0.5.0+2 for example and you are probably okay - until a source-incompatible change is made of course. It is just a temporary workaround any way. |
Thank you, I think I will take my changes and switch to chewie as you suggested. Thank you for your support and awesome work! |
I have updated some dependencies because they where conflicting with others in my project.
There are no breaking changes in their latest version