Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated non-breaking dependencies #636

Merged
merged 1 commit into from
Apr 28, 2021
Merged

chore: updated non-breaking dependencies #636

merged 1 commit into from
Apr 28, 2021

Conversation

abhinandval
Copy link
Contributor

I have updated some dependencies because they where conflicting with others in my project.
There are no breaking changes in their latest version

@erickok
Copy link
Collaborator

erickok commented Apr 27, 2021

Thanks for helping out. This partly conflict with the 2.0.0-final PR of #603. More importantly, you are using a manual override of some chewie version. I don't think we can accept that for our production release. Is this jsut because you want to update to the latest video_player?

@tneotia
Copy link
Collaborator

tneotia commented Apr 27, 2021

I don't think we can accept that for our production release.

It won't allow you to publish to Pub in the first place, all dependencies must be exclusively from Pub.

@abhinandval
Copy link
Contributor Author

can you review again i restored chewie

@abhinandval abhinandval reopened this Apr 28, 2021
@erickok erickok merged commit afc3808 into Sub6Resources:master Apr 28, 2021
@adrianvintu
Copy link

Version 2.0.0 still is incompatible for me

Because flutter_html >=2.0.0-nullsafety.0 depends on chewie ^1.0.0 and chewie >=1.1.0 requires SDK version >=2.13.0 <3.0.0, flutter_html >=2.0.0-nullsafety.0 requires chewie >=1.0.0 <1.1.0.

And because chewie >=1.0.0 <1.1.0 depends on wakelock ^0.4.0, flutter_html >=2.0.0-nullsafety.0 requires wakelock ^0.4.0.

And because flick_video_player 0.3.1 depends on wakelock ^0.5.0+2 and no versions of flick_video_player match >0.3.1 <0.4.0, flutter_html >=2.0.0-nullsafety.0 is incompatible with flick_video_player ^0.3.1.

I am using

flutter_html: ^2.0.0
flick_video_player: ^0.3.1

@erickok
Copy link
Collaborator

erickok commented May 28, 2021

@adrianvintu I know these are very annoying, but there isn't much we can do here as they are dependencies of our dependencies. You are probably best off using a dep_override on wakelock. Alternatively you could use chewie yourself for video playback instead of flick_video_player.

@adrianvintu
Copy link

@erickok sorry to hear that. I am quite a beginner in Flutter, so I don't really understand how these dependencies work.

Should I open a ticket on the chewie side and ask them to update wakelock?

I am thinking about switching to chewie btw, but these changes always come with a lot of pain.

@erickok
Copy link
Collaborator

erickok commented May 28, 2021

See https://dart.dev/tools/pub/dependencies#dependency-overrides on how to do a dependency override for your app. You can fix wakelock to ^0.5.0+2 for example and you are probably okay - until a source-incompatible change is made of course. It is just a temporary workaround any way.

@adrianvintu
Copy link

Thank you, I think I will take my changes and switch to chewie as you suggested. Thank you for your support and awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants