Iframe not scrolling issue fixed.

[sivaperumal644]

When Iframe is rendered the scrolling was not able to be done. It has been fixed.

[ryan-berger]

I'm not sure I can merge this pull request. This sort of a configuration change could break other people's code, because not everyone is using an iframe to render scrollable content.

I think the use of a custom renderer was created so you could do exactly this type of thing. If you want to propose an API change, let's discuss it here, but only changing the scrolling behavior isn't something I'm comfortable with.

[erickok]

In the (agreed: absolutely minimal) usage in the example app, the scrolling works just fine. What is the problem exactly?

[erickok]

I'm still not sure what the original issue was here?

[tneotia]

I don't know what the issue here was either, however I do think this can be merged safely. I just tested it, first building with the current implementation, tested scrolling (works fine), then switched it to the VerticalDragGestureRecognizer, hot restart, tested, works fine as well.

In the implementation of PlatformViewVerticalGestureRecognizer, @Sub6Resources states that it can be removed once this has been resolved, which it has via this PR.

If we do merge this I would suggest removing the PlatformViewVerticalGestureRecognizer beforehand.

[erickok]

While I agree that nothing seems broken with this PR, I also can't reproduce the actual issue so it is hard to tell if this fixes anything. Can you reproduce this @tneotia ? Android or iOS? Simulator or real device?

[tneotia]

@erickok No, for me scrolling is fine on all platforms (unlike tapping, which I will try and get back to you on very soon in #465). This PR is more of removing unnecessary/redundant code at this point, since @Sub6Resources created his own GestureDetector for the webview due to an issue in Flutter. Now that issue is resolved, so we no longer need the workaround and can transition back to the Flutter implementation.

[tneotia]

@erickok this can be closed via #543