Fix video aspect ratio #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this is the right fix, but it seems to solve the issue. |
The `ChewieController` doesn't use the aspect ratio from the container, leading to incorrect padding around the element. Fixes Sub6Resources#264
|
LGTM. Nice small fix. |
ryan-berger
approved these changes
Oct 5, 2020
|
Thanks for merging. I just realized that it was merged in the branch |
|
I think he merged it into master from this branch here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChewieControllerdoesn't use the aspect ratio from the container,leading to incorrect padding around the element.
Fixes #264