Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-parser]feat table and colgroup on new-parser branch. #176

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

dotneet
Copy link
Contributor

@dotneet dotneet commented Oct 21, 2019

This PR provides support for these tags:

  • table, thead, tbody, tfoot, tr, td
  • colgroup, col

Supported attributes of col in this PR is only width.
Fractional and fixed width is supported with col.

I think that colgroup and col are very useful for specifying the column style.
So I hope these tags will be supported.

@dotneet dotneet changed the title feat table and colgroup on new-parser branch. [new-parser]feat table and colgroup on new-parser branch. Oct 23, 2019
@Sub6Resources
Copy link
Owner

Thanks! I'll work on reviewing this and will merge it if there aren't any issues.

@Sub6Resources Sub6Resources added this to the 1.0.0 milestone Oct 23, 2019
@Sub6Resources Sub6Resources added 1.0.0 enhancement New feature or request labels Oct 23, 2019
@Sub6Resources Sub6Resources self-requested a review October 23, 2019 13:47
Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to create this pull request. Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants