feat: complete the feature

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe · Apr 7, 2024 · 9bf5468 · 9bf5468
1 parent 01dbbc1
commit 9bf5468
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/src/core/public/application/application_service.tsx b/src/core/public/application/application_service.tsx
@@ -265,7 +265,10 @@ export class ApplicationService {
         workspaces.currentWorkspaceId$.value &&
         targetApp?.visibility === AppVisibility.homeOnly
       ) {
+        // If user is inside a workspace and the target app is homeOnly
+        // refresh the page by doing a hard navigation
         window.location.assign(getAppUrl(availableMounters, appId, path));
+        return;
       }
 
       if (shouldNavigate) {

diff --git a/src/core/public/application/types.ts b/src/core/public/application/types.ts
@@ -272,7 +272,7 @@ export interface App<HistoryLocationState = unknown> {
    * Defaulting to `both`
    * See {@link AppVisibility}
    */
-  visibility: AppVisibility;
+  visibility?: AppVisibility;
 }
 
 /**

diff --git a/src/core/public/index.ts b/src/core/public/index.ts
@@ -130,6 +130,7 @@ export {
   AppUpdater,
   ScopedHistory,
   NavigateToAppOptions,
+  AppVisibility,
 } from './application';
 
 export {

diff --git a/src/plugins/home/public/plugin.ts b/src/plugins/home/public/plugin.ts
@@ -54,7 +54,7 @@ import { DataPublicPluginStart } from '../../data/public';
 import { TelemetryPluginStart } from '../../telemetry/public';
 import { UsageCollectionSetup } from '../../usage_collection/public';
 import { UrlForwardingSetup, UrlForwardingStart } from '../../url_forwarding/public';
-import { AppNavLinkStatus } from '../../../core/public';
+import { AppNavLinkStatus, AppVisibility } from '../../../core/public';
 import { PLUGIN_ID, HOME_APP_BASE_PATH } from '../common/constants';
 import { DataSourcePluginStart } from '../../data_source/public';
 
@@ -130,6 +130,7 @@ export class HomePublicPlugin
         const { renderApp } = await import('./application');
         return await renderApp(params.element, coreStart, params.history);
       },
+      visibility: AppVisibility.homeOnly,
     });
     urlForwarding.forwardApp('home', 'home');