bump to chicory 1.0 and wasm module interface annotation #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
WIll take a look tonight! |
anderseknert
approved these changes
Jan 8, 2025
Contributor
anderseknert
left a comment
anderseknert
left a comment
There was a problem hiding this comment.
Change looks good to me! Any docs that should be updated with this?
Collaborator
Author
|
Good call @anderseknert , I added a commit to test the |
Collaborator
Author
|
@anderseknert good to merge? |
Contributor
|
Good to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #38 , along with the bump I switched to the new
@WasmModuleInterfaceannotation to generate most of the boilerplate code.The only downside is that we lose the javadocs around the exported functions, though this should be arguably easier to maintain and free of human errors as the interface is directly extracted from the Wasm Module.
The changes to the user API are minimal, since we are still in
0.0.Xwe should be free of rolling them out.Happy to hear feedback about it 🙂 !