-
Notifications
You must be signed in to change notification settings - Fork 22
Add spanish folder #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you! I pushed a commit that copy-pasted the files from Italian into Spanish, since Spanish is quite similar to Italian, though there is some stuff that needs to be adapted and some hardcoded values that need to be changed in the kotlin files. Here is a build of Dicio based on that commit, you will see that now the timer and calculator skills are available in Spanish, too. And it also kind of works already, see the screenshot below, however it didn't understand "one million" for some reason. https://github.com/Stypox/testing-apks/releases/download/15/app-debug.apk To make this complete you would need to:
I would help you out but I don't know Spanish, though let me know if you have any question about the code 😬 |
Thank you. I made a few tweaks in the tokenizer. And I added the test folder to perform tests with Spanish. It will take a few days to complete the translation or adaptation. Hopefully I will finish it when I have some time. |
I asked Gemini 2.5 Pro to take on the challenge of adapting the code to follow the logic of the Spanish language and found it interesting that it made modifications in a matter of minutes, including absurd situations that I have not imagined to do (like "tres cientos" when the right word is "trescientos"). I hope this commit is useful for you to review and make other modifications ("lang" folder). |
Thanks! This is one of the first times I see LLMs actually being useful at writing code xD. I still had to fix a few compiler errors though. I built again an APK, https://github.com/Stypox/testing-apks/releases/download/20/app-debug.apk, that will allow you to test:
![]() |
I'm thinking that the app does not recognize words like “million” or “billion” in the singular but does recognize words like ‘millions’ and “biollons” in the plural. Examples of spanish phrases to numbers:
Perhaps the solution is to edit the multiplier block in tokenizer.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the continued effort, here is another APK: https://github.com/Stypox/testing-apks/releases/download/21/app-debug.apk
The tests don't compile at the moment, and there are plenty of errors (e.g. some methods being tested only exist for the english parser and not for the spanish one). Could you fix them (or prompt the ai to fix them)? Also, are you able to run tests yourself, so you can more easily iterate until they pass?
…with compound numbers which resembles Italian lang
I have asked the AI to correct several details. Now I have fixed tokenizer to identify composite numbers taking references from the Italian one which brought better results. I am doing also with date_time.json. About testing, I haven't managed to compile with APK because I haven't got it yet. Also, I'm using a lighter text editor. I'm sorry. |
Hello again. This PR is for adding a spanish-format numbers. I have added several parameters to test with dates and numbers. I hope it is useful, as I have tried to adapt as much as I could. If it is possible to test its operation, I thank you in advance.