Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'testable' with 'testables' #2

Merged
merged 2 commits into from
Aug 25, 2019
Merged

Rename 'testable' with 'testables' #2

merged 2 commits into from
Aug 25, 2019

Conversation

devxoul
Copy link
Contributor

@devxoul devxoul commented Aug 21, 2019

Rename testable with testables as @wplong11 suggested.

This PR breaks existing API:

- profileViewController.testable[\.usernameLabel]
+ profileViewController.testables[\.usernameLabel]

@devxoul devxoul requested a review from wplong11 August 21, 2019 13:09
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          13     13           
=====================================
  Hits           13     13
Impacted Files Coverage Δ
Sources/Testables/Testables.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5666e3...0040c53. Read the comment docs.

Copy link

@wplong11 wplong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@devxoul devxoul merged commit fec1603 into master Aug 25, 2019
@devxoul devxoul deleted the testables branch August 25, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants