Skip to content

Conversation

@jonkoops
Copy link
Collaborator

Moves all of the work done for CI to GitHub Actions, getting rid of Travis in the process.

@jonkoops
Copy link
Collaborator Author

I'll keep this PR in draft as the CI checks currently have some failures in them that we might want to resolve in separate PRs such as #940.

@jonkoops jonkoops mentioned this pull request Mar 16, 2025
@jonkoops jonkoops force-pushed the github-ci branch 5 times, most recently from f9b0baa to 22ccb9b Compare March 26, 2025 17:22
@jonkoops jonkoops requested a review from Copilot March 26, 2025 17:22

This comment was marked as resolved.

@jonkoops jonkoops force-pushed the github-ci branch 2 times, most recently from 814ca39 to d548850 Compare March 26, 2025 17:28
@jonkoops jonkoops marked this pull request as ready for review March 26, 2025 17:32
@jonkoops jonkoops requested a review from Copilot March 26, 2025 17:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates continuous integration from Travis to GitHub Actions. It introduces a composite action for setting up the workspace and defines multiple workflow jobs for linting, Node.js testing across a range of versions, browser testing, and benchmarking.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
.github/actions/setup/action.yml Adds a composite action to set up Node.js and install dependencies.
.github/workflows/main.yml Defines CI workflow jobs for linting, testing, browser tests, and benchmarking.
Files not reviewed (2)
  • .github/workflows/pr.yaml: Language not supported
  • .travis.yml: Language not supported

@jonkoops
Copy link
Collaborator Author

I've decided to change the approach here, the matrix now includes all versions where we can get the tests to pass, which I think is a good starting point. Adding support for newer and older versions of Node.js can be handled as a follow-up under #941 and #944.

Copy link
Owner

@Stuk Stuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Couple of comments about the benchmarking code, wondering if you know the answers? If not we could remove this functionality for the moment.

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops
Copy link
Collaborator Author

I spent a bit more time to look through the docs, and decided to split off the benchmarks into a separate workflow that only runs on the main branch, as per the recommendations from the documentation.

@jonkoops jonkoops requested a review from Copilot March 27, 2025 23:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transfers the existing continuous integration process from Travis to GitHub Actions by implementing new workflow configurations and a reusable composite action for setting up the workspace.

  • Added a main workflow (main.yml) for linting, Node.js testing, and browser testing.
  • Introduced a benchmark workflow (benchmark.yml) to run and report performance benchmarks.
  • Created a composite action (setup/action.yml) to standardize workspace setup across workflows.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
.github/workflows/main.yml Implements linting and tests (Node.js & browser) jobs.
.github/workflows/benchmark.yml Adds a workflow to run benchmarks and manage results.
.github/actions/setup/action.yml Defines a composite action to install Node.js and dependencies.
Files not reviewed (2)
  • .github/workflows/pr.yaml: Language not supported
  • .travis.yml: Language not supported

@Stuk Stuk merged commit 643714a into Stuk:main Mar 28, 2025
14 checks passed
@jonkoops jonkoops deleted the github-ci branch March 28, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants