-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Move all continuous integration to GitHub Actions #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll keep this PR in draft as the CI checks currently have some failures in them that we might want to resolve in separate PRs such as #940. |
f9b0baa to
22ccb9b
Compare
814ca39 to
d548850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates continuous integration from Travis to GitHub Actions. It introduces a composite action for setting up the workspace and defines multiple workflow jobs for linting, Node.js testing across a range of versions, browser testing, and benchmarking.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/actions/setup/action.yml | Adds a composite action to set up Node.js and install dependencies. |
| .github/workflows/main.yml | Defines CI workflow jobs for linting, testing, browser tests, and benchmarking. |
Files not reviewed (2)
- .github/workflows/pr.yaml: Language not supported
- .travis.yml: Language not supported
Stuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Couple of comments about the benchmarking code, wondering if you know the answers? If not we could remove this functionality for the moment.
Signed-off-by: Jon Koops <jonkoops@gmail.com>
|
I spent a bit more time to look through the docs, and decided to split off the benchmarks into a separate workflow that only runs on the main branch, as per the recommendations from the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR transfers the existing continuous integration process from Travis to GitHub Actions by implementing new workflow configurations and a reusable composite action for setting up the workspace.
- Added a main workflow (main.yml) for linting, Node.js testing, and browser testing.
- Introduced a benchmark workflow (benchmark.yml) to run and report performance benchmarks.
- Created a composite action (setup/action.yml) to standardize workspace setup across workflows.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/main.yml | Implements linting and tests (Node.js & browser) jobs. |
| .github/workflows/benchmark.yml | Adds a workflow to run benchmarks and manage results. |
| .github/actions/setup/action.yml | Defines a composite action to install Node.js and dependencies. |
Files not reviewed (2)
- .github/workflows/pr.yaml: Language not supported
- .travis.yml: Language not supported
Moves all of the work done for CI to GitHub Actions, getting rid of Travis in the process.