Typescript definitions: Fix JSZip.folder does not return null#857
Open
JamiesWhiteShirt wants to merge 1 commit intoStuk:mainfrom
Open
Typescript definitions: Fix JSZip.folder does not return null#857JamiesWhiteShirt wants to merge 1 commit intoStuk:mainfrom
JamiesWhiteShirt wants to merge 1 commit intoStuk:mainfrom
Conversation
|
ping @Stuk , I just found this issue today as well :) could this be merged please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#669 added null to the return type according to the documentation in the typedefs, but the documentation in the typedefs is wrong about
JSZip.folderreturning null.JSZip.folderdoes not return null.This fixes the documentation in the typedefs and the type to match the documented and observable behavior.