Update elFinderVolumeDriver.class.php #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite logic for to get mimeDetect for clarity and to resolve a small bug. This line causes a bug where it becomes impossible to set mimeDetect to 'mime_content_type': https://github.com/Studio-42/elFinder/blob/33eea861cb07196edbde5d9188f65a6ce81be21f/php/elFinderVolumeDriver.class.php#L1290 The logic here first makes an array of methods available in the current environment. Then we check to see if the type set is among them. If not, set to auto. If set to auto, shift the first element from available types.
|
@billynoah Thank you for fixing a bug. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite logic for to get mimeDetect for clarity and to resolve a small bug.
This line causes a bug where it becomes impossible to set mimeDetect to 'mime_content_type':
elFinder/php/elFinderVolumeDriver.class.php
Line 1290 in 33eea86
The logic here first makes an array of methods available in the current environment. Then we check to see if the type set is among them. If not, set to auto. If set to auto, shift the first element from available types.