Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless backend request during elFinder.sync() #3572

Closed
nao-pon opened this issue Jun 2, 2023 · 1 comment
Closed

Useless backend request during elFinder.sync() #3572

nao-pon opened this issue Jun 2, 2023 · 1 comment
Assignees

Comments

@nao-pon
Copy link
Member

nao-pon commented Jun 2, 2023

Describe the bug
If elFinder.sync() is called while elFinder.sync() is still running, useless backend requests will occur.
This is related to #3568.

To Reproduce
If the user has browser extensions installed that send a Message then this message is intercepted by js/elFinder.js:4827, and since the message is not a string of type JSON an exception is returned and the self.sync() method is called.
Using the example of the wappalyzer add-on - a dozen notifications are sent at once by which elFinder sends multiple requests at once to the application backend.

Expected behavior
New elFinder.sync() execution instructions should be ignored while elFinder.sync() is running.

Screenshots
image

@mbreliberty
Copy link

Maybe this note can be useful...

There is the same problem of infinite sync loop when the "react dev tools" firefox extention is enabled...
1 full day to understand this infinite loop... but i did it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants