Skip to content

introduce a formatting mistake #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

introduce a formatting mistake #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e98990b
introduce a formatting mistake
Maximilian-Stefan-Ernst Apr 19, 2024
d808da7
Merge branch 'devel' into test-formatter-action
Maximilian-Stefan-Ernst Apr 19, 2024
a62aa63
add write permission to workflow
Maximilian-Stefan-Ernst Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/FormatCheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
jobs:
code-style:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: julia-actions/julia-format@v2
with:
Expand Down
18 changes: 6 additions & 12 deletions src/loss/ML/ML.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,18 +459,12 @@ end
# objective, gradient ----------------------------------------------------------------------

function objective!(
semml::SemML,
par,
model::AbstractSemSingle,
has_meanstructure::Val{T},
imp::RAM,
) where {T}
let Σ = Σ(imply(model)),
Σₒ = obs_cov(observed(model)),
Σ⁻¹Σₒ = Σ⁻¹Σₒ(semml),
Σ⁻¹ = Σ⁻¹(semml),
μ = μ(imply(model)),
μₒ = obs_mean(observed(model))
semml::SemML,
par,
model::AbstractSemSingle,
has_meanstructure::Val{T}, imp::RAM) where T
let Σ = Σ(imply(model)), Σₒ = obs_cov(observed(model)), Σ⁻¹Σₒ = Σ⁻¹Σₒ(semml),
Σ⁻¹ = Σ⁻¹(semml), μ = μ(imply(model)), μₒ = obs_mean(observed(model))
Comment on lines +462 to +467
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
semml::SemML,
par,
model::AbstractSemSingle,
has_meanstructure::Val{T}, imp::RAM) where T
let Σ = Σ(imply(model)), Σₒ = obs_cov(observed(model)), Σ⁻¹Σₒ = Σ⁻¹Σₒ(semml),
Σ⁻¹ = Σ⁻¹(semml), μ = μ(imply(model)), μₒ = obs_mean(observed(model))
semml::SemML,
par,
model::AbstractSemSingle,
has_meanstructure::Val{T},
imp::RAM,
) where {T}
let Σ = Σ(imply(model)),
Σₒ = obs_cov(observed(model)),
Σ⁻¹Σₒ = Σ⁻¹Σₒ(semml),
Σ⁻¹ = Σ⁻¹(semml),
μ = μ(imply(model)),
μₒ = obs_mean(observed(model))


copyto!(Σ⁻¹, Σ)
Σ_chol = cholesky!(Symmetric(Σ⁻¹); check = false)
Expand Down