Open
Conversation
…on)" OpenRewrite recipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I pushed your changes a bit further, applied my proposed changes, used a few OpenRewrite recipes and upgraded a few things. There are, unfortunately, still places that desperately need some care. For example, we're still using Jetty 9, which went EOL long time ago. It should be upgraded to version 12.0 or 12.1, but it's not trivial. I didn't have found the time just yet to do that. Also, there's still this one test from you that's disabled. I'll try to fix that sometime this week.
I now also tested my app against it, and it looks like it's working. So at least Spring and Jackson parts should be OK. But I didn't test it too extensively (yet).
I'm creating a PR against your branch here, so that we could merge both your and mine changes to the main repository at the same time. Still, feel free to comment or reject the changes if you find them wrong.
Jacek