fix: remove ember initial data (#1101)

* remove data from ember route on serve and bump node plugin * changes
Strider-CD · Jul 11, 2020 · 8ce8c0e · 8ce8c0e · vercel · Jul 11, 2020
1 parent a7bee3a
commit 8ce8c0e
Show file tree

Hide file tree

Showing 8 changed files with 85,247 additions and 695 deletions.
diff --git a/apps/strider/dist-lib/routes/index.js b/apps/strider/dist-lib/routes/index.js
diff --git a/apps/strider/dist-lib/routes/index.js.map b/apps/strider/dist-lib/routes/index.js.map
diff --git a/apps/strider/dist/scripts/app.js b/apps/strider/dist/scripts/app.js
diff --git a/apps/strider/lib/routes/index.js b/apps/strider/lib/routes/index.js
@@ -68,19 +68,9 @@ exports.emberIndex = function (req, res) {
   }
 
   if (req.query.ember) {
-    return jobs.latestJobs(req.user, true, function (err, jobs) {
-      const availableProviders = Object.keys(common.userConfigs.provider).map(
-        function (k) {
-          return common.userConfigs.provider[k];
-        }
-      );
-      // TODO: only set if dev
-      res.header(
-        'Cache-Control',
-        'private, no-cache, no-store, must-revalidate'
-      );
-      res.render('ember/index.html', { jobs, availableProviders });
-    });
+    // TODO: only set if dev
+    res.header('Cache-Control', 'private, no-cache, no-store, must-revalidate');
+    res.render('ember/index.html');
   }
 };
 

diff --git a/apps/strider/package.json b/apps/strider/package.json
@@ -110,7 +110,7 @@
     "strider-heroku": "^0.2.0",
     "strider-mailer": "^0.2.0",
     "strider-metadata": "^0.0.3",
-    "strider-node": "^2.0.0",
+    "strider-node": "^2.0.1",
     "strider-python": "^0.2.1",
     "strider-ruby": "^0.0.2",
     "strider-simple-runner": "^2.0.0",

diff --git a/clients/strider-ui/app/index.html b/clients/strider-ui/app/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="en-us">
   <head>
     <meta charset="utf-8" />
     <meta http-equiv="X-UA-Compatible" content="IE=edge" />
@@ -18,9 +18,6 @@
   <body>
     {{content-for "body"}}
 
-    <script>
-      window.jobs = {{ jobs | scriptjson | raw }};
-    </script>
     <script src="{{rootURL}}assets/vendor.js"></script>
     <script src="{{rootURL}}assets/strider-ui.js"></script>
 

diff --git a/common/changes/strider/fix-remove-ember-initial-data_2020-07-11-13-29.json b/common/changes/strider/fix-remove-ember-initial-data_2020-07-11-13-29.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "strider",
+      "comment": "Remove serve time data from ember index route and bump node plugin",
+      "type": "patch"
+    }
+  ],
+  "packageName": "strider",
+  "email": "knownasilya@gmail.com"
+}
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml