Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #37 #41

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Fix for issue #37 #41

merged 1 commit into from
Aug 12, 2016

Conversation

ramirost
Copy link
Contributor

This PR fixes the issue #37 that can be reproduced when a job does not run the deploy phase.

@oliversalzburg
Copy link
Member

Would be nice if anyone could confirm this.

@ramirost
Copy link
Contributor Author

ramirost commented Aug 12, 2016

Of course is better if anybody else having the issue can test this but I can provide also more information to understand the fix.

When the a job is run without executing the deploy the phase object is something like this

captura de pantalla 2016-08-12 a las 10 40 33

The old code was checking always exitCode for deploy phase event when it was not executed and in such case exitCode was -1. The proposed fix only checks exitCode for deploy phase when finished is not null

@oliversalzburg oliversalzburg merged commit 8f7a9e6 into Strider-CD:master Aug 12, 2016
@oliversalzburg
Copy link
Member

Alright. I'll merge this, but I can't npm publish as I lack the permissions :P

@ramirost
Copy link
Contributor Author

Thanks, for us is ok if is included in the next release as we have version 1.4.2 patched locally.

@knownasilya
Copy link
Member

@oliversalzburg I added you to npm for this one as well 👍

@knownasilya
Copy link
Member

I added you to all the strider related repos I have access to, including gitane and dirkeeper.

@xyb
Copy link

xyb commented Oct 27, 2016

@knownasilya, @oliversalzburg, maybe it's time to release new version?

@oliversalzburg
Copy link
Member

Hmm, I just published 1.4.3. @knownasilya do we have a wiki article somewhere that describes the release process (we should)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants