fix(footer): changes to Layout.js and _document.js #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fixed position to the footer, so it always stays at the bottom of the page. This improves the layout of the page and makes it more user-friendly.
Remove the 'flex-1' class from the main element in the Layout component as it is not needed and can be simplified.
Previously, the body element in _document.js did not have any padding applied to it, causing some content to be obscured by the footer. This commit adds a relative position to the body element, as well as a bottom padding of 20px, to ensure that all content is visible.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello Punk! It's great having you contribute to this project
Welcome to the community
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our GitHub Organisation - we help and encourage each other to contribute to open source little and often . Any questions let us know.
darkterminal
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
# [1.2.0](v1.1.0...v1.2.0) (2023-03-29) ### Bug Fixes * **footer:** changes to Layout.js and _document.js ([#43](#43)) ([9bf6e47](9bf6e47)) * navbar link for mobile now match desktop links ([3475205](3475205)) * remove class\ footer need to be refactored ([d94b718](d94b718)) ### Features * add [@darkterminal](https://github.com/darkterminal) suggestion ([cf9c2b5](cf9c2b5)) * Add Tailwind responsive utility class ([#37](#37)) ([0fa0a38](0fa0a38)) * adding golang brand icon ([6f6a58a](6f6a58a)) * adding golang quotes ([dbf514b](dbf514b)) * display no story page ([c35a029](c35a029)) * **footer:** add fixed position to the footer ([6267e3b](6267e3b)) * **resp:** fix homepage responsivness ([00404bd](00404bd)) * **responsive:** add responsivness to pages ([96c7e0a](96c7e0a)) * update _document.js to add padding to body ([11195cc](11195cc))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What Your Metaphor
Changes to Layout.js and _document.js
👨💻 Suggest for Community (write if any)
Layout.jsto remove unnecessary class name and improve readability_document.jsfor better UI✔️ Check List (Check all the applicable boxes)
📄 Note to reviewers (write if any)
📷 What Your Punk Signature?