This repository has been archived by the owner on May 27, 2020. It is now read-only.
Ensure connections are being closed #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darroyocazorla
force-pushed
the
bug/connectionLeaks
branch
from
1dec5b0
to
064013d
Compare
This was referenced May 10, 2016
|
+1 |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the first step to solve the connections issue. As @wuciawe pointed out, there were several leaks.
Once the issue is solved, We'll clean up the MongodbClientFactory by removing the connection reuse because it's not working properly. Therefore, a new MongoClient will be created per partition.
Meanwhile, we will be working on the connection handler refactor, working with a single MongoClient instance per executor/config. It will be available soon (for 0.12.X)