Use serde_json APIs instead relying on value enum #51
Conversation
macisamuele
force-pushed
the
maci-use-serde_json-API-instead-relying-on-Value-enum
branch
from
582d365 to
5ecf3ae
Compare
| @@ -1,8 +1,19 @@ | |||
| use serde_json::Value; | |||
|
|
|||
| fn are_f64_equal(left: f64, right: f64) -> bool { | |||
| (left - right).abs() < 3. * f64::EPSILON | |||
There was a problem hiding this comment.
Why not comparison of left_num and right_num?
No probs :) I see that it does some negative impact on performance (however it is small in absolute numbers), e.g. with some |
|
I was noticing the performance hit, but overall absolute number were very low. Still I'm not 100% sure that json-trait-ts integration is feasible and reasonable. So I would eventually suggest to not merge this yet until some further tests are done |
|
@Stranger6667 I'm going to drop this for now as it does have a massive amount of merge conflicts as well as #86 might also simplify this effort as it would require a very localised diff and not on all the keywords. |
macisamuele
deleted the
maci-use-serde_json-API-instead-relying-on-Value-enum
branch
The goal of this PR is to decouple (as much as possible) from
serde_json.This is mostly needed to simplify the integration of
json-trait-rs(#30).I'm publishing this for initial review as it will be the base of the work for testing
json-trait-rs.I'm very sorry for the size of the PR ... :(