Skip to content

build: Fix GLIBCXX issue #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Fix GLIBCXX issue #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
ccache: sccache

steps:

# This is just easier than debugging different compilers on different platforms
- name: Set up Clang
if: ${{ matrix.name == 'Linux' }}
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
# with:
# path: C:\Program Files (x86)\Intel\oneAPI\ipp
# key: ipp-v1
#
#
# This lets us use sscache on Windows
# We need to install ccache here for Windows to grab the right version
- name: Install ccache (Windows)
Expand Down Expand Up @@ -173,12 +173,12 @@ jobs:
run: |
npm install -g appdmg
mkdir -p packaging/dmg

# Move built files to dmg folder
mv "${{ env.BUILD_DIR }}/${{ env.STANDALONE_PATH }}" packaging/dmg
mv "${{ env.BUILD_DIR }}/${{ env.VST3_PATH }}" packaging/dmg
mv "${{ env.BUILD_DIR }}/${{ env.AU_PATH }}" packaging/dmg

# Run appdmg to create the .dmg
cd packaging && appdmg dmg.json ${{ env.PRODUCT_NAME}}.dmg
codesign -s "${{ secrets.DEVELOPER_ID_APPLICATION}}" --timestamp -i com.StrangeLoops.gRainbow --force ${{ env.PRODUCT_NAME }}.dmg
Expand All @@ -196,7 +196,7 @@ jobs:
run: |
iscc "packaging\installer.iss"
mv "packaging/Output/${{ env.PRODUCT_NAME }}.exe" "${{ env.ARTIFACTS_PATH }}/"
#dotnet tool install --global AzureSignTool
#dotnet tool install --global AzureSignTool
#AzureSignTool sign -kvu "${{ secrets.AZURE_KEY_VAULT_URI }}" -kvi "${{ secrets.AZURE_CLIENT_ID }}" -kvt "${{ secrets.AZURE_TENANT_ID }}" -kvs "${{ secrets.AZURE_CLIENT_SECRET }}" -kvc ${{ secrets.AZURE_CERT_NAME }} -tr http://timestamp.digicert.com -v "${{ env.ARTIFACTS_PATH }}/${{ env.PRODUCT_NAME }}.exe"

- name: Upload Exe (Windows)
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
cmake_minimum_required(VERSION 3.4)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

# Avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24:
if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
Expand Down