Minimal traits for ADKG #59
Open
+196
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed-point and integer operations * division by constants, * preprocessing-storage traits * testing
This commit combines three PRs previously reviewed separately: 1. avoid premature clearing of messages 2. some testing improvements 3. some input improvements In more detail: 1. - See STO-177. 2. - better Debug impl for SessionId - avoid premature dropping of receivers - the same problem as STO-38. - avoid premature dropping of receiver - See STO-176. - make program exit on panic in any thread - add preprocessing_e2e test with BadFakeNetwork 3. - allow InputServer::init to be called before InputServer::input_handler - remove storage for random shares - only send masked inputs when reconstruction of random values has succeeded for the first time to avoid sending them multiple times - do not store more messages than 2t+1 to prevent a malicious node from spoofing sender IDs to act as if more nodes were sending random shares - add InputServer::wait_for_all_inputs, which either waits a given duration and then fails, or returns all inputs if they have arrived in this time; the previous solution used less encapsulation and always waited a fixed amount of time with no possibility to continue earlier - use one lock per InputClient instead of multiple - add some documentation
This commit combines three PRs previously reviewed separately: 1. avoid premature clearing of messages 2. some testing improvements 3. some input improvements In more detail: 1. - See STO-177. 2. - better Debug impl for SessionId - avoid premature dropping of receivers - the same problem as STO-38. - avoid premature dropping of receiver - See STO-176. - make program exit on panic in any thread - add preprocessing_e2e test with BadFakeNetwork 3. - allow InputServer::init to be called before InputServer::input_handler - remove storage for random shares - only send masked inputs when reconstruction of random values has succeeded for the first time to avoid sending them multiple times - do not store more messages than 2t+1 to prevent a malicious node from spoofing sender IDs to act as if more nodes were sending random shares - add InputServer::wait_for_all_inputs, which either waits a given duration and then fails, or returns all inputs if they have arrived in this time; the previous solution used less encapsulation and always waited a fixed amount of time with no possibility to continue earlier - use one lock per InputClient instead of multiple - add some documentation
# Conflicts: # mpc/src/honeybadger/fpmul/fpmul.rs # mpc/src/honeybadger/input/input.rs # mpc/src/honeybadger/mod.rs # mpc/tests/node_test.rs
Mikerah
reviewed
Dec 16, 2025
| self.operations.mul.wait_for_result(session_id, Duration::MAX).await.map_err(HoneyBadgerError::from) | ||
| } | ||
|
|
||
| async fn rand(&mut self, network: Arc<N>) -> Result<RobustShare<F>, Self::Error> { |
Contributor
There was a problem hiding this comment.
Since we are using the existing preprocessing_materials for rand, we'll need to carefully track the usage of rand vs mul to ensure that there are enough preprocessing materials. I would expect some of this functionality to be done on the VM side (cc'ing @gabearro)
Collaborator
Author
There was a problem hiding this comment.
Yea, there will be automatic calculation of the needed amount and yes the approx. number needed will be decided from @gabearro's side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.