[streams part 1] Refactor streams data fetching with useAsync #6412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewvolz
force-pushed
the
drew/streams-use-fetch
branch
from
6d8634f to
be89d87
Compare
drewvolz
force-pushed
the
drew/streams-use-fetch
branch
from
be89d87 to
dccbd7b
Compare
* add filter bar UI * show athletics streams by default
Closed
hawkrives
reviewed
Sep 18, 2022
Co-authored-by: Hawken Rives <hawkrives@fastmail.fm>
Co-authored-by: Hawken Rives <hawkrives@fastmail.fm>
Co-authored-by: Hawken Rives <hawkrives@fastmail.fm>
hawkrives
approved these changes
Sep 19, 2022
rye
previously requested changes
Sep 25, 2022
Member
Author
|
@rye did your questions get answered in this PR? |
[streams part 2] add category filtering to streams
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6412 +/- ##
=========================================
- Coverage 7.88% 7.86% -0.02%
=========================================
Files 289 289
Lines 5366 5375 +9
Branches 1382 1386 +4
=========================================
Hits 423 423
- Misses 4943 4952 +9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes refactor streams list to modernize the data fetching strategy to utilize a
useFetchcall.