🔖 news filtertoolbar

[drewvolz]

✨What this is

• A use of filter toolbar on story categories to give a little more depth to the news list.
• Part of the larger initiative to add filtering to more lists.

🗒️ Todo

• make the tests pass
  • Added @react-native to transformIgnorePatterns via ac12bc7 in All test suites are failing #6153
  • Adds @frogpond to transformIgnorePatterns via 1ff97cf
• a cleaner dependency array for buildFilters via e5f56e7
• need to fix a few typings (spec.selected)
• figure out what filter's apply: { key: should reference

📸 Screenshots

filtering	menu	none	empty

🎥 Demo

[drewvolz]

Anything more to do here? This is ready for another review.

[hawkrives]

… from a month ago

[hawkrives]

How sure are you that memoize doesn't use an unbounded cache? It'd be bad if we tried to fix one perf issue only to eat all available ram

[drewvolz]

I'm not sure about the bounding/unbounding sizes of memoize's cache.

Memoize's cache would be unbounded, yes.

Although we we have this pattern elsewhere in the codebase for large lists: course catalog and student orgs.

AAO-React-Native/source/views/sis/course-search/list.tsx

Lines 63 to 85 in 13c66f1

	let memoizedDoSearch = memoize(doSearch)
	// lodash supports this; the types do not.
	memoizedDoSearch.cache = new WeakMap()
	export const CourseResultsList = (props: Props): JSX.Element => {
	let navigation = useNavigation()
	let {
	filters,
	query,
	courses,
	applyFilters,
	onPopoverDismiss,
	contentContainerStyle,
	style,
	filtersLoaded,
	} = props
	// be sure to lowercase the query before calling doSearch, so that the memoization
	// doesn't break when nothing's changed except case.
	query = query?.toLowerCase()
	let results = memoizedDoSearch({query, filters, courses, applyFilters})

AAO-React-Native/source/views/student-orgs/list.tsx

Lines 34 to 44 in f422473

	const splitToArray = memoize((str: string) => words(deburr(str.toLowerCase())))
	const orgToArray = memoize((term: StudentOrgType) =>
	Array.from(
	new Set([
	...splitToArray(term.name),
	...splitToArray(term.category),
	...splitToArray(term.description),
	]),
	),
	)

[hawkrives]

Ok!

[drewvolz]

@rye thoughts? I think we've now got this cleaned up!