Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML, CSS, JS and JAVA corrections #810

Merged
merged 32 commits into from
Feb 16, 2024
Merged

HTML, CSS, JS and JAVA corrections #810

merged 32 commits into from
Feb 16, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Feb 14, 2024

Description

  • Missing HTML tags were added and the style was adjusted.
  • The currentPage attribute was added for login and account in the AccountWebController.
  • Darkmode.js has been adapted for the drop-down menu in the login.
  • The style sheet for outsourced to files.

Take time to examine the changes.

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner February 14, 2024 09:35
@Frooodle
Copy link
Member

You give me some nightmare PRs to review 😂

@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 14, 2024

I can't help it, it's like an accident, I just couldn't look away. But I need another day or two to correct things.

@Frooodle
Copy link
Member

Generally speaking raising a PR before changes are finished isnt the best, It sends us all emails but it also uses up the free minutes on the github action bots
OSS software only gets a set amount of free github action server time per month

@Ludy87
Copy link
Contributor Author

Ludy87 commented Feb 14, 2024

Sorry I used up your resources and flooded your email inbox.

The PR is ready to be audited.

@Frooodle Frooodle merged commit e4a76e9 into Stirling-Tools:main Feb 16, 2024
3 checks passed
@Ludy87 Ludy87 deleted the html_layout branch February 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants