Skip to content

Replace StateConnection Implementation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2020

Conversation

StevenLambion
Copy link
Owner

This PR removes the old state connection implementation for a simpler, reference-free one. The old implementation allows the state to be sliced up between views, but it requires an implementation that isn't SwiftUI friendly. It also adds complexity for a feature that isn't used in my own project and has been removed from the documentation of this libray.

Work Performed

  • Removed StateConnection
  • Refactored the Connector view to map the state to the ConnectableView's props.
  • Added StoreWrapper to inject the Store<_> object into the environment.
  • Removed storeUpdated environment value.

@StevenLambion StevenLambion changed the title Remove All Reference Types From the View Layer Replace StateConnection Implementation May 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   77.57%   77.57%           
=======================================
  Files          20       20           
  Lines         446      446           
=======================================
  Hits          346      346           
  Misses        100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2b5ff...c22a84a. Read the comment docs.

@StevenLambion StevenLambion merged commit a62ad65 into master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants