Open
Conversation
This can replace the email feature
Collaborator
Author
|
I haven't removed |
Owner
|
We will probably need an online version and a shiny live version. Sendslide is a must have function. The alternative would be to have code that disabled Sendslide functionality if running under shiny live.
Steven L. Shafer
Sent from my phon. Srry for N E tipografikl errrs.
…________________________________
From: Alexander Clarke ***@***.***>
Sent: Sunday, January 19, 2025 11:20:28 PM
To: StevenLShafer/stanpumpR ***@***.***>
Cc: Steven L Shafer ***@***.***>; Review requested ***@***.***>
Subject: Re: [StevenLShafer/stanpumpR] 126 add support for shinylive (PR #136)
@fifteenforty<https://github.com/fifteenforty> requested your review on: #136<#136> 126 add support for shinylive.
—
Reply to this email directly, view it on GitHub<#136 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFHWJTYCUV4K6LUQBLIAE232LR2QZAVCNFSM6AAAAABVPHGTGCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHE4TCNBTG4YTKMI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Collaborator
Author
|
No problem. I'll add a conditional so the email field only appears when credentials are set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
stanpumpRwith the purpose of makingstanpumpRcompatible withwebRandshinylive.Removal of unused packages and functions:
shinyBS,egg,grid,mailR,randomcoloR, andRColorBrewerfrom theImports:section.Removed sendError (email function)
R/sendError.R: Removed thesendErrorfunction which was used to send error messages via email.server.R: Removed the call tosendErrorin the server function.Addition of new download buttons
R/sendSlide.R: Added functionsgeneratePPTX,generateXLSX, andgeneratePNGto generate PowerPoint, Excel, and PNG reports respectively.server.R: AddeddownloadHandlerfor generating and downloading PPTX, XLSX, and PNG reports.global.R: Added a workaround for thedownloadButtonin Chromium-based browsers.Compatibility improvement
ui.R: Removedshinybs::bsTooltipelements as they were incompatible with shinylivebslib::tooltip()but this requires Bootstrap 5, so other dependencies will need to be updated first