fix off-by-one error in range check of Backlog::new (nix-rust#2500)

SteveLauC · Sep 17, 2024 · a0869f9 · a0869f9
1 parent b6f9cc3
commit a0869f9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/sys/socket/mod.rs b/src/sys/socket/mod.rs
@@ -2190,7 +2190,7 @@ impl Backlog {
 
         let val = val.into();
 
-        if !(MIN..Self::MAXCONN.0).contains(&val) {
+        if !(MIN..=Self::MAXCONN.0).contains(&val) {
             return Err(Errno::EINVAL);
         }
 

diff --git a/test/sys/test_socket.rs b/test/sys/test_socket.rs
@@ -1695,6 +1695,13 @@ pub fn test_named_unixdomain() {
     assert_eq!(&buf[..], b"hello");
 }
 
+#[test]
+pub fn test_listen_maxbacklog() {
+    use nix::sys::socket::Backlog;
+
+    assert!(Backlog::new(libc::SOMAXCONN).is_ok());
+}
+
 #[test]
 pub fn test_listen_wrongbacklog() {
     use nix::sys::socket::Backlog;