Fixed some warnings

SteveBarnegren · Oct 19, 2017 · 8c138eb · 8c138eb
1 parent b8ed2b3
commit 8c138eb
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 13 deletions.
diff --git a/SwiftChess/Source/AIPlayer.swift b/SwiftChess/Source/AIPlayer.swift
@@ -252,21 +252,19 @@ open class AIPlayer : Player {
 
         let location = pawnsToPromoteLocations.first!
 
-        guard let piece = board.getPiece(at: location) else {
+        guard board.getPiece(at: location) != nil else {
             return board
         }
 
         // Get the ratings
-        var bestType = Piece.PieceType.possiblePawnPromotionResultingTypes().first
-        var bestRating = -Double.greatestFiniteMagnitude
+        var highestRating = -Double.greatestFiniteMagnitude
         var promotedBoard: Board!
 
         for pieceType in Piece.PieceType.possiblePawnPromotionResultingTypes() {
 
             var newBoard = board
 
-            guard let piece = newBoard.getPiece(at: location) else {
-
+            guard newBoard.getPiece(at: location) != nil else {
                 return board
             }
 
@@ -275,9 +273,8 @@ open class AIPlayer : Player {
 
             let rating = ratingForBoard(newBoard)
 
-            if rating > bestRating {
-                bestRating = rating
-                bestType = pieceType
+            if rating > highestRating {
+                highestRating = rating
                 promotedBoard = newBoard
             }
 
@@ -310,7 +307,6 @@ internal class BoardRater {
 
     func ratingfor(board: Board, color: Color) -> Double{
         fatalError("Override ratingFor method in subclasses")
-        return 0
     }
 }
 

diff --git a/SwiftChess/Source/ASCIIBoard.swift b/SwiftChess/Source/ASCIIBoard.swift
@@ -7,7 +7,6 @@
 //
 
 import Foundation
-import SwiftChess
 
 func transformASCIIBoardInput(_ input: String) -> String{
 

diff --git a/SwiftChess/Source/Board.swift b/SwiftChess/Source/Board.swift
@@ -532,7 +532,7 @@ public struct Board : Equatable {
 
             let location = BoardLocation(x: xPos, y: castleMove.yPos)
 
-            if let piece = getPiece(at: location) {
+            if getPiece(at: location) != nil {
                 return false
             }
 

diff --git a/SwiftChess/Source/BoardRaterCenterFourOccupation.swift b/SwiftChess/Source/BoardRaterCenterFourOccupation.swift
@@ -15,7 +15,6 @@ class BoardRaterCenterFourOccupation: BoardRater {
         let value = Double(1);
         var rating = Double(0)
 
-        BoardLocation(x: 3, y: 3)
         let locations = [
             BoardLocation(x: 4, y: 4), // NE
             BoardLocation(x: 4, y: 3), // SE

diff --git a/SwiftChess/Source/PieceMovement.swift b/SwiftChess/Source/PieceMovement.swift
@@ -354,7 +354,6 @@ open class PieceMovementPawn: PieceMovement {
         let color = movingPiece.color
 
         // ****** Test forward locations ******
-        var forwardStrides = [BoardStride]()
 
         // Test one ahead offset
         let oneAheadStride = (color == .white ? BoardStride(x: 0, y: 1) : BoardStride(x: 0, y: -1))
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,7 +7,6 @@ @@
     //
     import Foundation
-    import SwiftChess
     func transformASCIIBoardInput(_ input: String) -> String{
@@ Expand Down @@