Make solve optional for Code quiz#4
Merged
Conversation
meanmail
approved these changes
Dec 19, 2017
|
|
||
| class BaseQuiz(object): | ||
| attrs = ['check', 'solve'] | ||
| export_attrs = ['check', 'solve'] |
Contributor
There was a problem hiding this comment.
Может лучше назвать required_attr, вроде смысл такой?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Кто должен одобрить:
Функция
solveв коде Code квиза сделана необязательной. Если присутствует, проверяется корректная сигнатура и поведения остается, как и было раньше.solveотсутствует:generateвозвращает список строк (датасетов), то командаgenerateвернет список пар(dataset, clue), гдеclue=None;generateвозвращает список пар(dataset, clue), то командаgenerateвернет этот же список.Только для Code квиза добавлена команда
has_solve, возвращаетbool— определена или нет функцияsolveв коде квиза.Добавлены тесты.