Feat/persist with json #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an interface for persisting and retrieving project data using JSON serialization, including methods for writing and reading project lists.
…ad of strings Adjust JSON read/write methods to handle `Project` objects, ensuring type consistency and better alignment with domain model.
Introduce comprehensive tests to validate the behavior of `ProjectJsonReaderWriterImpl`, including scenarios for empty input, null handling, overwriting data, and field preservation.
Include `jackson-databind` dependency for JSON processing support.
Add `app.projects.file` property pointing to `test-projects.json` to support test project setup.
Introduce `app.projects.file` configuration property to specify the JSON file path for project data. Add `JsonConfig` for `ObjectMapper` bean definition. Update `ProjectJsonReaderWriterImpl` to handle reading and writing `Project` objects as JSON.
Refactor `ProjectRepository` to utilize `ProjectJsonReaderWriter` for JSON-based project persistence. Load projects on initialization and write changes to JSON upon modifications.
Closed
Comment on lines
+20
to
+22
| @TestPropertySource(properties = { | ||
| "app.projects.file=test-projects.json" | ||
| }) |
Member
Author
There was a problem hiding this comment.
This is unnecessary since we've specified the property in the test application.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.