Implement from_raw and into_raw #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanvanSchaik
force-pushed
the
from_into_raw
branch
from
0c97b56 to
b03e3cb
Compare
StephanvanSchaik
force-pushed
the
from_into_raw
branch
5 times, most recently
from
82439f4 to
8718e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Mmap::into_raw()to turn an existing memory mapping object into a raw pointer and the size of the memory mapping. After calling this function the user is responsible for the memory previously managed by the memory mapping object.In addition, this PR implements
Mmap::from_raw()to create a memory mapping object from a raw pointer and a size. This is unsafe since the user can call this function more than once for the same raw pointer, which would result in a double-free. Furthermore, the current implementation does not check whether the memory mapping has the appropriate permissions, or whether it even exists.