Refactor Shell. Remove ShellOut.#34
Merged
albertodebortoli merged 20 commits intomasterfrom Mar 27, 2023
Merged
Conversation
malcommac
requested changes
Mar 23, 2023
Member
Author
|
Ok chaps, sorted by reintroducing @malcommac's code :) I tried on a different mac where my user is in the wheel group (see https://superuser.com/questions/20420/what-is-the-difference-between-the-default-groups-on-mac-os-x). I'm still not clear on the details of user management in unix but frankly I'm not interested now. ChatGPT will teach me anyway next time I need this :) I've also added the shared schemes for StellarEnv. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR initially aimed to remove ShellOut in favour of Apple's TSCBasic but I couldn't wrap my head around it without first reworking Shell.
Shellto have a clearer interface that only wraps the underlying shell fromTSCBasic(e.g. avoid duplication ofProcess)Shell(it has stdout and stderr and best to leave print statements at the call sites to avoid mixing responsibilities)ShelltoShell+Commandsto have clear responsibilitieswhichanddownloadResourcecommands as they are unused. They seem to be leftovers from Added StellarEnv to manage and communicate with stellar installed versions #24.ShellErrorandProcessResult+Throwingsudoas not needed (/usr/local/binis writable without sudo) and wasn't working (it exits the program as needs user input)