Merged
Conversation
| enumerator(at: location, includingPropertiesForKeys: [], options: []) | ||
| } | ||
|
|
||
| public func copyFile(from location: URL, to destination: URL) throws { |
Member
Author
There was a problem hiding this comment.
BundleService is now using the existing implementation of copy(at... on line 41 in this file.
It is OK as the code in BundleService checks for the existence of the target folder and deletes it if existing.
malcommac
approved these changes
Mar 13, 2023
Contributor
malcommac
left a comment
malcommac
left a comment
There was a problem hiding this comment.
approved with embarrassment
xl4kj
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend inspecting the individual commits to simplify the review.
Some points:
tuist --helpto see how it's inconsistent in Tuist for instance. Like for the commits (that I use to write starting with a verb in the infinite form, see here and here), there is no widely-adopted convention I think.