Fixed performance problems on startup while sorting the download list…

… (Issue fmd-project-team#383)
Stella-Hoshineko · Sep 6, 2019 · cec97bd · cec97bd
1 parent 0c13278
commit cec97bd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/baseunits/uDownloadsManager.pas b/baseunits/uDownloadsManager.pas
@@ -1114,9 +1114,6 @@ procedure TTaskContainer.SetEnabled(AValue: Boolean);
 constructor TTaskContainer.Create;
 begin
   inherited Create;
-
-  if OptionSortDownloadsWhenAddingNewDownloadTasks then
-    DLManager.Sort(DLManager.SortColumn);
 
   DlId := -1;
   InitCriticalSection(CS_Container);

diff --git a/baseunits/uSilentThread.pas b/baseunits/uSilentThread.pas
@@ -16,7 +16,7 @@ interface
 
 uses
   SysUtils, fgl, uBaseUnit, uData, uDownloadsManager,
-  WebsiteModules, FMDOptions, httpsendthread, BaseThread, LazFileUtils;
+  WebsiteModules, FMDOptions, httpsendthread, BaseThread, LazFileUtils, MultiLog;
 
 type
 
@@ -185,6 +185,8 @@ procedure TSilentThreadManager.Add(AType: TMetaDataType;
     finally
       LeaveCriticalsection(FCS_META);
     end;
+    if OptionSortDownloadsWhenAddingNewDownloadTasks then
+      DLManager.Sort(DLManager.SortColumn);
   end;
 end;
 

diff --git a/mangadownloader/forms/frmMain.pas b/mangadownloader/forms/frmMain.pas
@@ -2521,8 +2521,8 @@ procedure TMainForm.btDownloadClick(Sender: TObject);
           CurrentDownloadChapterPtr:=0;
           SaveToDB(newdl);
         end;
-		if OptionSortDownloadsWhenAddingNewDownloadTasks then
-		  DLManager.Sort(DLManager.SortColumn);
+        if OptionSortDownloadsWhenAddingNewDownloadTasks then
+          DLManager.Sort(DLManager.SortColumn);
       end;
       DLManager.DownloadedChapters.Chapters[mangaInfo.website+mangaInfo.link]:=links.Text;
       FavoriteManager.AddToDownloadedChaptersList(mangaInfo.website,mangaInfo.link,links);
@@ -4067,7 +4067,9 @@ procedure TMainForm.vtDownloadDragDrop(Sender : TBaseVirtualTree;
       vtDownloadMoveItems(vtDownload.DropTargetNode^.Index, Mode);
   end
   else
+  begin
     AddSilentThread(frmDropTarget.GetDropURLs(DataObject), MD_DownloadAll);
+  end;
 end;
 
 procedure TMainForm.vtDownloadDragOver(Sender : TBaseVirtualTree;