Tests: Enable analysis of multiple test markers in a test file #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, thank you so much for fixing this! I had some issue with multiple markers, where I couldn't find what went wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #952.
As described in the issue, currently only the first marker is evaluated (see file
CodeMarkup.csmethodGetLocator).This PR adds support for all markers, while keeping the existing option to only test for one (the first) marker.
Two new methods for all markers were added, and i applied them to all the test classes:
HasDiagnosticAtAllMarkersandNoDiagnosticAtAllMarkers.It seems that most test cases were still correct, the only error this change surfaced was a testcase for LC0005:
If this change is correct and should be merged, then it may be good to check any PRs that are outstanding or were merged in the meantime to also use the "all markers" methods.
Any feedback is very much welcome :)