Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC0068: fix permissions interrupted by pragmas or comments #949

Merged

Conversation

ans-bar-bm
Copy link
Contributor

@ans-bar-bm ans-bar-bm commented Feb 19, 2025

Fixes #923.

Replaces the string based analysis of the whole permissions property text with individual analysis of the PermissionPropertyValueSyntax's PermissionProperties.
With this change permissions by object id will also be analysed correctly (though they shouldn't be used according to the other rules).

@ans-bar-bm
Copy link
Contributor Author

Seems with version 15 additional null checks would be required, is there a simple way to test these version specifics locally?
I just run with the version of the LoadALLanguageDependency task, if there is a way to ensure version compatibility without too much effort before submitting a PR please let me know :)

@Arthurvdv
Copy link
Collaborator

Thank you for looking into the issue and providing an PR for this! 🙌

these version specifics locally?

In the LoadALLanguage.ps1 file located in the .vscode folder, you find this line;

$vsixUrl = $listing.results.extensions.versions | Where-Object properties -ne $null | Where-Object { $_.properties.key -contains 'Microsoft.VisualStudio.Code.PreRelease' } | Select-Object -First 1 -ExpandProperty files | Where-Object { $_.assetType -eq 'Microsoft.VisualStudio.Services.VSIXPackage' } | Select-Object -ExpandProperty source;

Change $_.properties.key -notcontains 'Microsoft.VisualStudio.Code.PreRelease' to $_.properties.key -contains 'Microsoft.VisualStudio.Code.PreRelease', then you'll get the most recent Pre-release of the AL Language, which is currently v15.0.1290655.

PS Don't forget to change the AL Language extension in VS Code itself also to the Pre-release, so that the locally build LinterCop.dll is build against the same version of the AL LLanguage extension in VS Code itself.

@ans-bar-bm
Copy link
Contributor Author

Thanks, i've updated the code for the changes in AL version 15.

@Arthurvdv Arthurvdv merged commit 8573420 into StefanMaron:prerelease Feb 20, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants