Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve diagnostic message on System.Date2DMY(Date, Integer) Method #921

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Resolve diagnostic message on System.Date2DMY(Date, Integer) Method #921

merged 1 commit into from
Feb 4, 2025

Conversation

Arthurvdv
Copy link
Collaborator

I had based the rule on the table of the in the changelog, we're an mistake was made.

image
https://marketplace.visualstudio.com/items/ms-dynamics-smb.al/changelog

The suggestion of the diagnostic was wrong, where this PR fixes this.

Type New method Existing Description
Date MyDate.DayOfWeek() Date2DWY(MyDate, 1) Gets the day of week from MyDate
Date MyDate.WeekNo() Date2DWY(MyDate, 2) Gets the week number from MyDate
Date MyDate.Year() Date2DWY(MyDate, 3) Gets the year from MyDate

@Arthurvdv Arthurvdv merged commit 79ad12e into prerelease Feb 4, 2025
26 checks passed
@Arthurvdv Arthurvdv deleted the Rule0083Bugfix branch February 4, 2025 15:16
@Arthurvdv Arthurvdv mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arthurvdv